More Housebreaking

I am in a delima with my male and female dogs. They are 17 months old and we have been deligent it trying to train them. We have kept them in crates and not let them have the run of the house and when they are out we let them out to go potty very often. The male especially hikes his leg every where. What can I do? How do I respond?
June Purnell